Conversation
k0kubun
force-pushed
the
bundler-workaround
branch
from
93a14bc to
638f87f
Compare
XrXr
approved these changes
Aug 1, 2025
Contributor
|
Small nit: is there a way to upgrade bundler without upgrading packages? That might change benchmark results in weird and subtle ways |
Member
Author
Yes, but we occasionally update libraries anyway. You can't freeze libraries forever and keep them running. That's part of yjit-bench maintenance. |
Member
Author
|
Filed Shopify/yjit-metrics#417 to explain the potential impact on benchmarks. |
This was referenced Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
BUNDLED WITHin Gemfile.lock to 2.8.0.dev as a workaround for Shopify/ruby#622. It also bumps the gem versions not locked in Gemfile to ease this work. I pinned hexapdf and ruby-lsp versions since upgrading them break the benchmark though.When you run the current yjit-bench with Ruby master, Bundler currently re-execs itself and drops JIT options. I don't know how yjit-metrics works around it, but I have no way to locally run YJIT or ZJIT with benchmarks that have Gemfile.lock. Because the repro condition is limited to Gemfile.lock having non-
2.8.0.devversion in BUNDLED WITH for Ruby master, this PR uses2.8.0.devas BUNDLED WITH to fix the problem. I confirmed that Ruby 3.4.5 works with this Gemfile.lock.